google / google/closure-templates

SoyToJsSrcCompiler.jar is out of date

Open
#747 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
700
Forks
199
Avg merge
2d 12h
Merged PRs (30d)
26

Description

In the download at https://dl.google.com/closure-templates/closure-templates-for-javascript-latest.zip referenced in https://github.com/google/closure-templates/blob/master/documentation/codelabs/helloworlds/helloworld_js.md, the provided file for `SoyToJsSrcCompiler.jar` is out of date. It does not support the current syntax and has outdated flags. Please provide an updated version of the jar file and related resources. Also consider including these updates in future releases so this isn't continually out of date.

Example error:
```
Exception in thread "main" com.google.template.soy.base.SoySyntaxException: In file index.soy: Unsupported attribute 'visibility' in 'template' command text (visibility="private").
at com.google.template.soy.base.SoySyntaxException.createWithoutMetaInfo(SoySyntaxException.java:52)
at com.google.template.soy.soytree.CommandTextAttributesParser.parse(CommandTextAttributesParser.java:109)
at com.google.template.soy.soytree.TemplateBasicNodeBuilder.setCmdText(TemplateBasicNodeBuilder.java:107)
at com.google.template.soy.soytree.TemplateBasicNodeBuilder.setCmdText(TemplateBasicNodeBuilder.java:47)
at com.google.template.soy.soyparse.SoyFileParser.Template(SoyFileParser.java:300)
at com.google.template.soy.soyparse.SoyFileParser.SoyFile(SoyFileParser.java:277)
at com.google.template.soy.soyparse.SoyFileParser.parseSoyFile(SoyFileParser.java:192)
at com.google.template.soy.soyparse.SoyFileSetParser.parseSoyFileHelper(SoyFileSetParser.java:266)
at com.google.template.soy.soyparse.SoyFileSetParser.parseWithVersions(SoyFileSetParser.java:213)
at com.google.template.soy.soyparse.SoyFileSetParser.parse(SoyFileSetParser.java:173)
at com.google.template.soy.SoyFileSet.compileToJsSrcFiles(SoyFileSet.java:921)
at com.google.template.soy.SoyToJsSrcCompiler.execMain(SoyToJsSrcCompiler.java:303)
at com.google.template.soy.SoyToJsSrcCompiler.main(SoyToJsSrcCompiler.java:243)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.