google / google/closure-compiler

replaceMessages occurs during the check phase

Open
#697 0 comments 0 reactions 0 assignees View on GitHub
internal cleanup
Dominant language
JavaScript
Stars
7.7k
Forks
1.2k
Avg merge
2d 12h
Merged PRs (30d)
6

Description

replaceMessages (i18n) strings occur during the check phase. It it is costly to resolve message ids, we should consider have a "check mode" that runs if optimizations aren't going to run so that AST doesn't change. So the rewriting occurs during the optimization phase.

The currently occurs before "processDefines" but I don't think that is a requirement.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.