google / google/closure-compiler

JSDocInfo class should be immutable

Open
#408 0 comments 0 reactions 0 assignees View on GitHub
internal cleanup P2
Dominant language
JavaScript
Stars
7.7k
Forks
1.2k
Avg merge
2d 12h
Merged PRs (30d)
6

Description

The JSDocInfo class has several mutation functions (addSuppression), etc. The class should either be fully mutable or immutable. As it is generally immutable, it is best that it be immutable as this makes caching and copying the AST safer.

The "associated node" should also be removed (as it makes it possible to leak and misassociate nodes). It is only used in a few places and it appears that it would be reasonable to replace.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.