google / google/closure-compiler
`Array.pop` and `Array.shift` methods do not get type-checked correctly
- Dominant language
- JavaScript
- Stars
- 7.7k
- Forks
- 1.2k
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 6
Description
`Array.pop` and `Array.shift` methods do not get type-checked correctly, at least not by Typescript standards.
Example:
```js
/**
* @param {Array} names
*/
function hello(names) {
/** @type {string} */
const name = names.pop() // should raise an error, `name` can be undefined
}
```
```js
/**
* @param {Array} names
*/
function hello(names) {
/** @type {string} */
const name = names.shift() // should raise an error, `name` can be undefined
}
```
Compiler Version: v20221102
Build command:
```
java -jar ./scripts/closureCompiler.jar \
--entry_point=./src/js/index.js \
--js=./src/**.js \
--dependency_mode=PRUNE \
--warning_level=VERBOSE \
--js_output_file=./dist/bundle.js \
--module_resolution=WEBPACK \
--compilation_level=ADVANCED \
--jscomp_error=checkDebuggerStatement \
--jscomp_error=unusedLocalVariables \
--jscomp_error=reportUnknownTypes \
--jscomp_error=strictCheckTypes;
```
Contributor guide
Assessment
This issue has not been assessed yet.