google / google/closure-compiler

Base element's static method with nocollapse shouldn't be collapsed in subclasses.

Open
#3,771 5 comments 0 reactions 0 assignees View on GitHub
enhancement feat P2
Dominant language
JavaScript
Stars
7.7k
Forks
1.2k
Avg merge
2d 12h
Merged PRs (30d)
6

Description

In this scenario:

```
class BaseClass {
/** @nocollapse */
static getSomething() {}
}

class SubClass {
/** @override */
static getSomething() {}
}
```

The `SubClass`'s `getSomething` static method gets collapsed and removed. However, an overriden static method like this should stay since it's kept in the superclass.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.