google / google/closure-compiler

DOMMatrix constructor parameter should be optional.

Open
#3,768 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.7k
Forks
1.2k
Avg merge
2d 12h
Merged PRs (30d)
6

Description

Repeating from the comment at https://github.com/google/closure-compiler/pull/3730#pullrequestreview-585356152.

At https://github.com/google/closure-compiler/pull/3730 the DOMMatrix externs were added. According to the [specification](https://www.w3.org/TR/geometry-1/#dommatrix) the `init` constructor parameter should be marked as optional.

![dom_matrix_constructor](https://user-images.githubusercontent.com/7547039/107208076-eeb88800-69b5-11eb-96d7-e5fb6de957a1.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.