google / google/closure-compiler

FR: Avoid 'incomplete alias created' warning if aliasing is known to be safe

Open
#3,428 1 comment 1 reaction 0 assignees View on GitHub
internal-issue-created triage-done
Dominant language
JavaScript
Stars
7.7k
Forks
1.2k
Avg merge
2d 12h
Merged PRs (30d)
6

Description

See the most recent comments on https://github.com/google/closure-compiler/issues/2595.

Right now `CollapseProperties` warns for aliasing a namespace if any properties on that namespace may be unsafely collapsed. (i.e. if there are constructors or enums on the namespace)

In cases like https://github.com/google/closure-compiler/issues/2595, though, the only usage of the aliased namespace is to access a function property (which is not collapsible). The compiler should be able to determine that this is safe and not warn.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.