google / google/closure-compiler

Unresolved task detected: DependencyInfo "TODO(sdh): This would be better as a defender method once Java 8 is allowed (b/28382956)"

Open
#2,839 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.7k
Forks
1.2k
Avg merge
2d 12h
Merged PRs (30d)
6

Description

We found this task where the condition satisfied but action was not taken:

- src/com/google/javascript/jscomp/deps/DependencyInfo.java:186
```
// TODO(sdh): This would be better as a defender method once Java 8 is allowed (b/28382956):
// void DependencyInfo#writeAddDependency(Appendable);
```

- The trigger: "Java 8 is allowed" happened around commit <62ba0abf5ed74070a644284cb8e51d9e3d6dc9eb> (Oct 11 2017).

- But the action: "This would be better as a defender method" never happened since then.

- The new language features in Java 8 can be utilized, i.e. to add a default implementation for `writeAddDependency(Appendable)` in `interface DependencyInfo`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.