google / google/closure-compiler

Insufficient test coverage to ensure that compiler releases work with Angular

Open
#2,664 17 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.7k
Forks
1.2k
Avg merge
2d 12h
Merged PRs (30d)
6

Description

Angular is selling our users on Closure Compiler - as of Angular 4 we provide some support at http://github.com/angular/closure-demo
It's also a key part of our "develop like google does" story: http://g.co/ng/abc

However, we frequently find that closure releases are broken. Currently 20170409 is the latest release that works with Angular - however it won't work with Angular 5 because we need some recent fixes to node module resolution.

We should ensure that a green build of closure will work with Angular.

we should be able to copy what closure-library does to run their end-to-end tests externally, and use that to run the closure compiler IntegrationTest (currently it only runs in google-internal)

/cc @gregmagolan @MatrixFrog

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.