google / google/closure-compiler

es6 classes should copy parent class constructor signature

Open
#2,583 3 comments 0 reactions 0 assignees View on GitHub
help wanted P3
Dominant language
JavaScript
Stars
7.7k
Forks
1.2k
Avg merge
2d 12h
Merged PRs (30d)
6

Description

```
class Parent {
/** @param {string} value */
constructor(value) {}
}

class Child1 extends Parent {}
class Child2 extends Parent {
/** @override */
constructor(...args) {
super(...args);
}
}
class Child3 extends Parent {
/** @param {string} value */
constructor(value) {
super(value);
}
}

new Parent(1); // OK
new Child1(1); // NO WARNING
new Child2(2); // NO WARNING
new Child3(2); // OK

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.