google / google/closure-compiler

streamsapi.js externs: Sink / Source types too strict?

Open
#2,108 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.7k
Forks
1.2k
Avg merge
2d 12h
Merged PRs (30d)
6

Description

All the Promise-returning methods for ReadableStreamSource and ReadableStreamSink can actually return thenables.

This means that, for example, the return type specified here is too strict:

``` javascript
/** @type {(undefined|function(*):(!Promise<*>|undefined))} */
ReadableStreamSource.prototype.cancel;
```

I haven't actually had a real problem with this, I just work on the Streams standard. It may well be that there's no need to make this requirement more relaxed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.