google / google/closure-compiler

Closure Compiler can't deal with transpile.js

Open
#2,051 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.7k
Forks
1.2k
Avg merge
2d 12h
Merged PRs (30d)
6

Description

Closure Rules has been mistakenly passing Closure Library's [transpile.js](https://github.com/google/closure-library/blob/master/closure/goog/transpile.js) to the Closure Compiler. Recently, I've been noticing it causes build flakes.

Even though I'm removing this on my end, it's probably worth fixing the compiler so a giant file marked `@nocompile` doesn't cause the compiler to crash.

```
ERROR: /home/travis/build/bazelbuild/rules_closure/closure/library/BUILD:22:1: Checking 811 JS files in //closure/library:library failed: ClosureUberAlles failed: error executing command
(cd /home/travis/.cache/bazel/execroot/rules_closure && \
exec env - \
bazel-out/local-fastbuild/bin/java/io/bazel/rules/closure/ClosureUberAlles @bazel-out/local-fastbuild/bin/closure/library/library_worker_input): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1.
external/closure_library/closure/goog/transpile.js:1460: ERROR - Parse tree too deep.
_.dg=function wY(){return this.f.a};_.eg=function xY(){return jY(this).eg()};_.fg=function yY(){return jY(this).fg()};_.gg=function zY(){return this.a.gg()};_.yd=function AY(){return this.f.a};var KE=K9b(118);gQ(614,1,{},DY);var JE=K9b(614);gQ(159,1,{},NY);_.yd=function PY(){return Cd(zd(Ad(Ad(zd(zd(zd(Ad(Ad(zd(zd(Ad(Ad(Ad(Ad(yd(Ad(Ad(Ad(Ad(Ad(Ad(Ad(Ad(zd(zd(zd(zd(zd(Ad(zd(zd(zd(Ad(zd(Ad(Ad(Ad(Ad(Ad(zd(zd(Ad(Ad(zd(zd(zd(zd(zd(zd(zd(zd(zd(zd(zd(zd(zd(Ad(Ad(zd(zd(zd(zd(zd(zd(zd(zd(zd(zd(zd(zd(zd(zd(Ad(zd(zd(Ad(Ad(zd(zd(zd(zd(Ad(zd(Ad(Ad(yd(zd(zd(Ad(yd(zd(zd(Ad(Ad(zd(zd(Ad(zd(Ad(Ad(Ad(Ad(Ad(Ad(Ad(zd(zd(zd(zd(zd(zd(zd(zd(zd(Ad(Ad(zd(zd(zd(zd(zd(Ad(zd(zd(zd(Ad(Ad(Ad(zd(zd(zd(Ad(Ad(Ad(zd(zd(zd(Ad(zd(Ad(Ad(zd(Ad(zd(zd(Ad(Ad(Ad(zd(zd(zd(zd(zd(Ad(zd(zd(zd(zd(zd(zd(Ad(zd(zd(zd(zd(zd(zd(Ad(Ad(Ad(Ad(Ad(zd(zd(Ad(zd(zd(Ad(Ad(zd(zd(zd(Ad(Ad(zd(Ad(zd(Bd(new Dd((E9b(WE),
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.