google / google/closure-compiler

HTMLElement.dataset key can be encoded as an invalid identifier

Open
#1,747 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.7k
Forks
1.2k
Avg merge
2d 12h
Merged PRs (30d)
6

Description

HTMLElement.dataset key can be encoded as an invalid identifier.

`element.dataset.abc = 5;` can be compiled to `e.dataset.$a` where element is an HTMLElement. '$' character is not in the allowed identifiers list for [HTMLElement.dataset](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dataset) keys.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.