google / google/certificate-transparency-go

jsonclient backoff is never reset

Open
#1,696 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.2k
Forks
322
Avg merge
3d 4h
Merged PRs (30d)
5

Description

There are no calls to `jsonclient.(*backoff).decreaseMultiplier()` anywhere but in tests, so after a few `set` invocations, `multiplier` reaches 8 (`maxMultiplier`) and then always returns 128s. This means that after a bit in production, JSONClient will wait 128s upon every network error.

Contributor guide

Open the contributing guide

Research direction

Search the Go code for `jsonclient.(*backoff)`, `set`, and `decreaseMultiplier`, then read the existing backoff tests first. Determine where the multiplier should be reduced or reset in production and add regression coverage showing it does not remain at `maxMultiplier` after repeated operations.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.