google / google/capirca

shade_check does not raise an error but only prints a warning, produces no output file, and exit status 0

Open
#358 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
857
Forks
213
PR merge metrics
No merged PRs in 30d

Description

We've noticed that `aclgen --shade_check` does not raise an error (as described in the README) but only prints a warning, produces no output file, and exits with status 0. We expected the command to fail in such a case i.e. actually produce both, a more grave log message e.g. level *error* as well as exit status != 0.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.