google / google/capirca

Cisco remarks missing quotes

Open
#299 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
857
Forks
213
PR merge metrics
No merged PRs in 30d

Description

Hi,
We are using Capirca to generate Cisco like ACLs and we came across a weird issue.
When adding multiple words comments in the policies the required quotes are not in the generated filters.

See example:

Policy file:
```
term allow-ping {
comment:: "allow ping from NET to NET_GW"
```

The output is:
```
remark allow-ping
remark allow ping from NET to NET_GW
```

Obviously the second remark is invalid since it should be rendered like:
` remark "allow ping from NET to NET_GW"`

Are we missing something here or is it something that needs to be fixed?
Thank al lot.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.