google / google/capirca

Caprica is does not render an ICMP protocol term with the fragments option

Open
#181 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
857
Forks
213
PR merge metrics
No merged PRs in 30d

Description

Within the cisco/Term/__str__ function the fragments option is allowed for the IP protocol but not for ICMP. What do you think about adding:

if ('icmp' in protocol) and ('fragments' in opts):
if 'fragments' not in self.options:
self.options.append('fragments')

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.