google / google/caliper

Existence of finalizer causes experiment to fail (@ instrument=micro)

Open
#264 0 comments 0 reactions 0 assignees View on GitHub
component: runner P4 status: accepted type=defect
Dominant language
Java
Stars
818
Forks
112
Avg merge
12m
Merged PRs (30d)
5

Description

```
During prototyping of an object pool [1], I added a finalizer on the handle to
detect resource leaks (e.g. due to race conditions). When running a simple
benchmark with Caliper 1.0b1 it consistently failed by exceeding the trial
period. I temporarily reverted 0.5rc1 whose behavior differs enough that my
benchmark worked.

Later when actually performance tuning and my tests were robust, I removed the
finalizer. This improved performance as expected, as well as let 1.0b1 succeed.

[1] https://github.com/ben-manes/multiway-pool
```

Original issue reported on code.google.com by `Ben.Manes@gmail.com` on 14 Jul 2013 at 10:38

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.