google / google/bumble

Please help check IO Capability Handling

Open
#796 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
555
Forks
138
Avg merge
3d 15h
Merged PRs (30d)
9

Description

Hi Bumble Team,

I’ve been using the `on_authentication_user_confirmation_request` method in `device.py` and noticed that some IO capability combinations currently result in `na` (not available) methods, which may be incomplete.
For example,
- when `peer_io_capability` is `KEYBOARD_ONLY` and `local_io_capability` is `DISPLAY_YES_NO`, the method is currently marked as `na`, but based on the IO capability logic, it should be: `display_number` for the local device and `passkey_entry` for the remote device

Do you have any plans to implement these missing cases?

Additionally, I found a few combinations that seem to be incorrectly mapped:
For example,
- when both `peer_io_capability` and `local_io_capability` are `DISPLAY_ONLY`, the method should be `auto_confirm`, not `display_auto_confirm`.
- when `peer_io_capability` is `NO_INPUT_NO_OUTPUT` and `local_io_capability` is `DISPLAY_ONLY`, the method should also be `auto_confirm`, not `confirm`.

Could you please help verify these mappings and let me know if any updates are planned?

Thanks for your time and support!

Image

Best Regards,
Can Wang

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.