No Pairing Confirmation When Peripheral Does Not Use Secure Connections
- Dominant language
- Python
- Stars
- 555
- Forks
- 138
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 9
Description
## Summary
I'm working with two peripherals; one that is running on BLE 5, and one that uses BLE 4. I have `bumble` set up as the Central. On the BLE 5 peripheral, Secure Connections are enabled. On the BLE 4 peripheral they are not. When running a pairing test, the `PairingDelegate` gets prompted for user confirmation in `on_smp_pairing_random_command_secure_connections()`: https://github.com/google/bumble/blob/main/bumble/smp.py#L1794. This does not happen in `on_smp_pairing_random_command_legacy()`: https://github.com/google/bumble/blob/main/bumble/smp.py#L1653.
When either peripheral is used with a mobile device (iOS or Android), the mobile device will always prompt the user for confirmation, regardless of if the software initiated pairing (Android).
## Request
Would it be possible to have `on_smp_pairing_random_command_legacy()` also prompt for confirmation of pairing when the pairing method is `JUST_WORKS`? This would be closer to how pairing is handled on mobile devices where user confirmation is always requested.
Contributor guide
Assessment
This issue has not been assessed yet.