Compile error on ARMv7 platform
- Dominant language
- TypeScript
- Stars
- 14.9k
- Forks
- 1.4k
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 9
Description
ghoscript builds all the sources (including brotli) using -Werror=declaration-after-statement which causes build failure of brotli/c/dec/decode.c when targeting ARMv7 platform.
That's because PreloadSymbol() starts with a statement followed by BROTLI_HC_MARK_TABLE_FOR_FAST_LOAD() macro which on ARMv7 expands to variable declaration.
See https://bugs.ghostscript.com/show_bug.cgi?id=708831 for details and a proposed patch.
Contributor guide
Research direction
Start with brotli/c/dec/decode.c, focusing on PreloadSymbol() and BROTLI_HC_MARK_TABLE_FOR_FAST_LOAD() as they expand for ARMv7. Reproduce the build with -Werror=declaration-after-statement and compare the behavior with the proposed patch in the linked report. Done means the ARMv7 build completes without this declaration-order error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100