Suggest a rework for DictionaryData in java port.
- Dominant language
- TypeScript
- Stars
- 14.9k
- Forks
- 1.4k
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 9
Description
just, don't make a 123KB class if not have to. that is not a good way.
a better practice would be:
1. remove the reflection in Dictionary.
2. rework DictionaryData to load from resources file.
3. move the load part from static part to method invocation part, and make a 2-step-sync to the loading part.
would be glad to impl it if you would arrange time for the code review.
Contributor guide
Research direction
Locate the Java port's Dictionary and DictionaryData classes, then trace how reflection and static initialization currently load the dictionary. Assess the proposed resource-file loading and two-step synchronization approach. Done means the large generated class and reflection-based loading have been reworked as described, with the loading behavior preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100