google / google/brotli

makefile broken

Open
#1,094 7 comments 5 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
14.9k
Forks
1.4k
Avg merge
4d 20h
Merged PRs (30d)
9

Description

hi,

just tried to compile the new nginx 1.25.3 with brotli but cannot

`make -f objs/Makefile modules
make[1]: Entering directory `/usr/src/nginx-1.25.3'
cc -c -fPIC -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -Wno-deprecated-declarations -I src/core -I src/event -I src/event/modules -I src/event/quic -I src/os/unix -I ../ngx_brotli/deps/brotli/c/include -I objs -I src/http -I src/http/modules \
-o objs/addon/filter/ngx_http_brotli_filter_module.o \
../ngx_brotli/filter/ngx_http_brotli_filter_module.c
cc -c -fPIC -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -Wno-deprecated-declarations -I src/core -I src/event -I src/event/modules -I src/event/quic -I src/os/unix -I ../ngx_brotli/deps/brotli/c/include -I objs -I src/http -I src/http/modules \
-o objs/ngx_http_brotli_filter_module_modules.o \
objs/ngx_http_brotli_filter_module_modules.c
cc -o objs/ngx_http_brotli_filter_module.so \
objs/addon/filter/ngx_http_brotli_filter_module.o \
objs/ngx_http_brotli_filter_module_modules.o \
-L../ngx_brotli/deps/brotli/c/../out -lbrotlienc -lbrotlicommon -lm \
-shared
**/usr/bin/ld: cannot find -lbrotlienc
/usr/bin/ld: cannot find -lbrotlicommon**
collect2: error: ld returned 1 exit status
make[1]: *** [objs/ngx_http_brotli_filter_module.so] Error 1
make[1]: Leaving directory `/usr/src/nginx-1.25.3'
`

Contributor guide

Open the contributing guide

Research direction

Start with nginx-1.25.3's objs/Makefile and the ../ngx_brotli/deps/brotli/c/../out library path shown in the linker command. Reproduce make -f objs/Makefile modules and verify whether libbrotlienc and libbrotlicommon are produced or discoverable there; done means the module links without the reported errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, nginx
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.