google / google/brax

Documentation bug: wrong observation and action spaces ordering

Open
#483 3 comments 1 reaction 1 assignee Claimed by @Velythyl View on GitHub
good first issue
Dominant language
Jupyter Notebook
Stars
3.2k
Forks
349
PR merge metrics
No merged PRs in 30d

Description

I'm currently doing a project related to transferring control policies from simulator to simulator. This lead me to try to standardize action and observation spaces between brax and mujoco.

I implemented wrappers that map the obs and action spaces from mujoco to brax, according to each's table description

- brax: https://github.com/google/brax/blob/main/brax/envs/ant.py
- mujoco: https://gymnasium.farama.org/environments/mujoco/ant/

I found out that gymnasium's mujoco and gym's mujoco report different index orders for the action and observation spaces.
https://github.com/Farama-Foundation/Gymnasium/issues/1035

I then tried completely removing my mapping wrapper (maps mujoco's obs and action orders to brax's), only to find that my agent transfers a LOT better to mujoco from brax.

All this to say, I'm fairly sure that brax's doc reports the wrong ordering for the action and observation spaces (at least for Ant) and that gymnasium's doc should by copy-pasted into brax

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.