google / google/brax

Reacher observation appears to be mislabled

Open
#248 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
3.2k
Forks
349
PR merge metrics
No merged PRs in 30d

Description

In the docstring for the `Reacher` environment, two of the elements of the observation are the angular velocities of the two arms.

Inside `_get_obs` it seems to me that the two elements that are the "angular velocities" in the observation are actually the x and y coordinate of the linear velocity of the fingertip (relative to the world).

Relevant snippet (some lines omitted) from `Reacher._get_obs`
```python
arm_qps = jp.take(qp, jp.array(self._arm_idx))
tip_pos, tip_vel = arm_qps.to_world(jp.array([0.11, 0., 0.]))

qvel = [tip_vel[:2]]
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.