google / google/bloaty

incorrect TOTAL when diffing same binary

Open
#335 0 comments 3 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
5.5k
Forks
378
Avg merge
23h 54m
Merged PRs (30d)
6

Description

Since https://github.com/google/bloaty/pull/313/files (specifically https://github.com/google/bloaty/commit/7c5547aeac42917c0d58e19b77332cd07f122a02) the diff will incorrectly contain the new total size.

E.g
```
$ ./build/bloaty ./build/bloaty -- ./build/bloaty
FILE SIZE VM SIZE
-------------- --------------
+100% +7.30Mi +100% +7.55Mi TOTAL
```

Previously the report was correct:
```
$ bloaty /usr/bin/bloaty -- /usr/bin/bloaty
FILE SIZE VM SIZE
-------------- --------------
[ = ] 0 [ = ] 0 TOTAL
```

This make diff almost unusable because the actual TOTAL change is not calculated.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.