google / google/bindiff

[Bug] Error when build

Open
#84 0 comments 4 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
3.2k
Forks
240
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
I got error when build
tiendoan@M3-Pro bindiff % cmake --build build/out --config Release
[0/2] Re-checking globbed directories...
[571/578] Building CXX object CMakeFiles/bindiff.dir/main_portable.cc.o
FAILED: [code=1] CMakeFiles/bindiff.dir/main_portable.cc.o
/usr/bin/c++ -I/Users/tiendoan/bindiff/build/out/_deps/absl-src -I/Users/tiendoan/bindiff/build/binexport -I/Users/tiendoan/bindiff/build/binexport/stubs -I/Users/tiendoan/bindiff/build/out/_deps/binexport-build/gen_include -I/Users/tiendoan/bindiff/build/out/_deps/binexport-build/src_include -I/Users/tiendoan/bindiff/build/binexport/boost_parts -I/Users/tiendoan/bindiff/build/out/_deps/protobuf-src/src -I/Users/tiendoan/bindiff/build/out/_deps/protobuf-src/third_party/utf8_range -I/Users/tiendoan/bindiff/build/out/src_include -I/Users/tiendoan/bindiff/build/out/gen_include -I/Users/tiendoan/bindiff -O3 -DNDEBUG -std=c++17 -flto=thin -arch arm64 -fPIE -Wno-nullability-completeness -Wno-invalid-noreturn -Wno-deprecated -gfull -MD -MT CMakeFiles/bindiff.dir/main_portable.cc.o -MF CMakeFiles/bindiff.dir/main_portable.cc.o.d -o CMakeFiles/bindiff.dir/main_portable.cc.o -c /Users/tiendoan/bindiff/main_portable.cc
/Users/tiendoan/bindiff/main_portable.cc:216:23: error: no matching constructor for initialization of 'absl::MutexLock'
absl::MutexLock lock(g_queue_mutex);
^ ~~~~~~~~~~~~~
/Users/tiendoan/bindiff/build/out/_deps/absl-src/absl/synchronization/mutex.h:590:12: note: candidate constructor not viable: no known conversion from 'absl::Mutex' to 'Mutex *' for 1st argument; take the address of the argument with &
explicit MutexLock(Mutex* absl_nonnull mu) ABSL_EXCLUSIVE_LOCK_FUNCTION(mu)
^
/Users/tiendoan/bindiff/build/out/_deps/absl-src/absl/synchronization/mutex.h:604:3: note: candidate constructor not viable: no known conversion from 'absl::Mutex' to 'const MutexLock' for 1st argument
MutexLock(const MutexLock&) = delete; // NOLINT(runtime/mutex)
^
/Users/tiendoan/bindiff/build/out/_deps/absl-src/absl/synchronization/mutex.h:605:3: note: candidate constructor not viable: no known conversion from 'absl::Mutex' to 'MutexLock' for 1st argument
MutexLock(MutexLock&&) = delete; // NOLINT(runtime/mutex)
^
/Users/tiendoan/bindiff/build/out/_deps/absl-src/absl/synchronization/mutex.h:598:12: note: candidate constructor not viable: requires 2 arguments, but 1 was provided
explicit MutexLock(Mutex* absl_nonnull mu, const Condition& cond)
^
1 error generated.
[573/578] Building C object CMakeFiles/sqlite.dir/_deps/sqlite-src/sqlite3.c.o
ninja: build stopped: subcommand failed.

**Environment (please complete the following information):**
- OS and version: MacOS
- Disassembler and version: SDK IDA 9.1

**Additional context**
I saw commit b3ba8f81d1296585b710512c3cc2e9697e2c1298 remove & in absl::MutexLock lock. I just add & back and can build

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.