google / google/bigwheels

[Fluid simulation] Fix address mode in compute samplers to resolve bloom issues

Open
#51 0 comments 0 reactions 1 assignee Claimed by @dnovillo View on GitHub
fluid simulation
Dominant language
C++
Stars
107
Forks
42
PR merge metrics
No merged PRs in 30d

Description

Address the problems discussed in https://github.com/google/bigwheels/pull/20#discussion_r1060677696_

This breaks the bloom
![broken-bloom](https://user-images.githubusercontent.com/4282252/210385331-a0c28bfe-a862-4780-b9a5-7d4926eef2d6.png)

changing it to REPEAT fixes it (should only be applied for this texture, not the speed one and others, otherwise speed will leak around the edges.
![fixed-bloom](https://user-images.githubusercontent.com/4282252/210384941-6f8d2aa8-6105-43e9-b463-7d7f6f96892c.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.