google / google/bigwheels

Check for required Vulkan device features

Open
#484 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
107
Forks
42
PR merge metrics
No merged PRs in 30d

Description

I was running BigWheels on pixel 6 (which I haven't done in a while) and it failed with feature not present. I couldn't immediately see which feature was not present.
Turns out it is fillModeNonSolid enabled in https://github.com/google/bigwheels/blob/main/src/ppx/grfx/vk/vk_device.cpp#L259
I think we should either:
- Enable features required for the project only (so in this case since it is needed by one application, control it there)
- Or at least, check for features and print which ones are not available

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.