google / google/bigwheels

[glTF] Scenes with a camera are not rendered correctly

Open
#473 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
107
Forks
42
PR merge metrics
No merged PRs in 30d

Description

Some examples:

- [Duck](https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/Duck) is mostly off-screen

| Expected | Actual |
| --- | --- |
| ![image](https://github.com/google/bigwheels/assets/3687359/47527983-2943-42f1-beb1-c221e4f29e19) | ![image](https://github.com/google/bigwheels/assets/3687359/973bdab2-73d5-4c67-bd0b-91a28493e692) |

- [EnvironmentTest](https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/EnvironmentTest) doesn't show anything:

| Expected | Actual |
| --- | --- |
| ![image](https://github.com/google/bigwheels/assets/3687359/62991dc8-e904-4996-bd27-8b9e4e864278) | ![image](https://github.com/google/bigwheels/assets/3687359/03412dec-1ccf-49cc-98ae-b8b9e1244035) |

- [IridescentDishWithOlives](https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/IridescentDishWithOlives) is stretched. Subsections of [3.10.3](https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#projection-matrices) say that

> When the provided camera’s aspect ratio does not match the aspect ratio of the viewport, client implementations SHOULD NOT crop or perform non-uniform scaling (“stretching”) to fill the viewport.

| Expected | Actual |
|---|---|
| ![image](https://github.com/google/bigwheels/assets/3687359/50ed96a4-fb9a-42ac-aa3b-04eebf829416) | ![image](https://github.com/google/bigwheels/assets/3687359/311ad44d-3813-4e6e-b1be-9dc2a1ded3c5) |

- [ToyCar](https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/ToyCar) is also similarly stretched

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.