google / google/bigwheels

Remove the need for PPX_BUILD_XR in project level code

Open
#415 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
107
Forks
42
PR merge metrics
No merged PRs in 30d

Description

For example in graphics benchmark app: https://github.com/google/bigwheels/blob/main/benchmarks/graphics_pipeline/GraphicsBenchmarkApp.cpp having to add PPX_BUILD_XR complicates code unnecessarily.
We should define the XR functions with or without PPX_BUILD_XR and make sure they behave appropriately if PPX_BUILD_XR=0, we can still have PPX_BUILD_XR in application.cpp.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.