google / google/bigwheels

Fluid simulation - Uniformise splat radius across screen aspects

Open
#29 0 comments 0 reactions 1 assignee Claimed by @dnovillo View on GitHub
enhancement fluid simulation
Dominant language
C++
Stars
107
Forks
42
PR merge metrics
No merged PRs in 30d

Description

context: https://github.com/google/bigwheels/pull/20/files/66100b1682d1ce7b4566417f90bcb1f7494c5eb3#r1060646881

When changing the aspect ratio, the simulation aspect changes because the radius of slats is only taken into account for wide screens, not tall ones.

This should be fixable by multiplying radius by aspect in all cases.
![before-after](https://user-images.githubusercontent.com/4282252/210378528-791b98d8-3c40-4d16-bbef-22df9712f19a.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.