ICC sysinfo fixes
Open
good first issue
help wanted
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.8k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
sysinfo fails to compile on OSX with ICC due to two issues:
error #2259 is caused by the return value from sysinfo.cc:558 being implicitly cast from `unsigned long long` to `double`.
error #177 is caused by methods at sysinfo.cc:112 `ValueUnion::GetAsString` and sysinfo:114 `ValueUnion::GetAsInteger` being unused.
To resolve this we should:
1. add an explicit cast for `hz` to `double`
2. add `-wd177` to the ICC compiler flags
Contributor guide
Assessment
This issue has not been assessed yet.