Use of cmake 3.6 feature with cmake_minimum_required (VERSION 2.8.12)
Open
enhancement
help wanted
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.8k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 8
Description
https://github.com/google/benchmark/commit/e776aa0275e293707b6a0901e0e8d8a8a3679508 This commit adds `list(FILTER SOURCE_FILES EXCLUDE REGEX "benchmark_main\\.cc")` line to https://github.com/google/benchmark/blob/master/src/CMakeLists.txt. `list(FILTER` was introduced in CMake 3.6, however you script sets minimum required CMake version at `2.8.12`.
Contributor guide
Assessment
This issue has not been assessed yet.