google / google/benchmark

[BUG] gcc-4 is not supported in release after 1.8.0

Open
#1,639 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
10.4k
Forks
1.8k
Avg merge
2d 4h
Merged PRs (30d)
8

Description

**Describe the bug**
The project is not compilable with gcc-4 since release 1.8.0, is gcc-4 no longer supported or the documentation need modification?

**System**
Which OS, compiler, and compiler version are you using:
- OS: CentOS 7.6.1810
- Compiler and version: gcc 4.8.5

**To reproduce**
Steps to reproduce the behavior:
1. checkout release version 1.8.0
2. cd ${source_code_folder} && mkdir build && cd build && cmake -DBENCHMARK_ENABLE_GTEST_TESTS=OFF ../
3. make
4. See error
```
[ 1%] Building CXX object src/CMakeFiles/benchmark.dir/benchmark.cc.o
/home/test/test/benchmark-1.8.0/src/benchmark.cc: In constructor ‘benchmark::State::State(std::string, benchmark::IterationCount, const std::vector&, int, int, benchmark::internal::ThreadTimer*, benchmark::internal::ThreadManager*, benchmark::internal::PerfCountersMeasurement*)’:
/home/test/test/benchmark-1.8.0/src/benchmark.cc:163:74: error: declaration of ‘name’ shadows a member of 'this' [-Werror=shadow]
internal::PerfCountersMeasurement* perf_counters_measurement)
^
/home/test/test/benchmark-1.8.0/src/benchmark.cc: In member function ‘void benchmark::State::PauseTiming()’:
/home/test/test/benchmark-1.8.0/src/benchmark.cc:230:12: error: declaration of ‘name’ shadows a member of 'this' [-Werror=shadow]
auto name = name_and_measurement.first;
^
cc1plus: all warnings being treated as errors
make[2]: *** [src/CMakeFiles/benchmark.dir/benchmark.cc.o] Error 1
make[1]: *** [src/CMakeFiles/benchmark.dir/all] Error 2
make: *** [all] Error 2
```

**Expected behavior**
The project should be compilable in gcc-4 or the document need an update that gcc-4 is no longer supported.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.