google / google/benchmark

[FR] cc_libraries should use "includes", not "strip_include_prefix"

Open
#1,512 3 comments 1 reaction 0 assignees View on GitHub
enhancement help wanted
Dominant language
C++
Stars
10.4k
Forks
1.8k
Avg merge
2d 4h
Merged PRs (30d)
8

Description

So that when users import google-benchmark, the headers are included as "system headers", instead of regular headers.

If this is not done, compilers will throw warnings at google-benchmark code, which users have no way to act upon. Users should be able to choose a highly restrictive set of warnings without having to fix them in google-benchmark.

Note that this pattern is already applied in the googletest repo.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.