google / google/autofdo

migrate to new api of abseil-cpp

Open
#254 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
619
Forks
127
PR merge metrics
No merged PRs in 30d

Description

https://github.com/abseil/abseil-cpp/commit/caf854d58c061808bae2a41f2b7da21a3ba74028#diff-a84ab48de639246d3e520df4c5ea31d325b4e5bd473cd4a8beec558712d06d48

abseil-cpp has deprecated template type alias nullability annotations in May 2025, and remove in Aug 2025. If trying to build autofdo with new abseil-cpp put into thirdparty, it fails with:
```
In file included from /home/lkp/rpmbuild/BUILD/autofdo-0.30.1/mini_disassembler.cc:1:
/home/lkp/rpmbuild/BUILD/autofdo-0.30.1/mini_disassembler.h:26:31: error: 'Nonnull' is not a member of 'absl'
26 | static absl::StatusOr>>
| ^~~~~~~
/home/lkp/rpmbuild/BUILD/autofdo-0.30.1/mini_disassembler.h:26:71: error: template argument 1 is invalid
26 | static absl::StatusOr>>
| ^~
/home/lkp/rpmbuild/BUILD/autofdo-0.30.1/mini_disassembler.h:26:73: error: expected unqualified-id before '>' token
26 | static absl::StatusOr>>
| ^
/home/lkp/rpmbuild/BUILD/autofdo-0.30.1/mini_disassembler.cc:27:22: error: 'Nonnull' is not a member of 'absl'
27 | absl::StatusOr>>
| ^~~~~~~
/home/lkp/rpmbuild/BUILD/autofdo-0.30.1/mini_disassembler.cc:27:62: error: template argument 1 is invalid
27 | absl::StatusOr>>
| ^~
/home/lkp/rpmbuild/BUILD/autofdo-0.30.1/mini_disassembler.cc:27:64: error: expected unqualified-id before '>' token
27 | absl::StatusOr>>
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.