google / google/autofdo

[bug] No checking about "requires the first loadable segment to be executable".

Open
#171 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
619
Forks
127
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/google/autofdo/commit/54991ff59ee2920c255ed0efa16687e488d7b1f9, remove checking about "requires the first loadable segment to be executable".
If first loadable segment isn't RE. It's bad to transfer runtime address to binary address.
Why autofdo doesn't use propeller's code about runtime address to binary address?https://github.com/google/autofdo/blob/master/perfdata_reader.cc#L386C2-L395C56

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.