warning: "CHECK_LE" redefined
- Dominant language
- C++
- Stars
- 619
- Forks
- 127
- PR merge metrics
- No merged PRs in 30d
Description
I see a spew of warnings that various gtest macros are redefined:
```
...
In file included from ../third_party/glog/src/base/commandlineflags.h:62,
from ../profile.cc:13:
third_party/glog/glog/logging.h:1009: warning: "DCHECK_EQ" redefined
1009 | #define DCHECK_EQ(val1, val2) CHECK_EQ(val1, val2)
|
In file included from ../third_party/perf_data_converter/src/quipper/binary_data_utils.h:16,
from ../third_party/perf_data_converter/src/quipper/perf_parser.h:20,
from ../sample_reader.h:18,
from ../profile.h:15,
from ../profile.cc:5:
../third_party/perf_data_converter/src/quipper/base/logging.h:144: note: this is the location of the previous definition
144 | #define DCHECK_EQ(x, y) CHECK_EQ(x, y)
|
In file included from ../third_party/glog/src/base/commandlineflags.h:62,
from ../profile.cc:13:
third_party/glog/glog/logging.h:1010: warning: "DCHECK_NE" redefined
1010 | #define DCHECK_NE(val1, val2) CHECK_NE(val1, val2)
|
In file included from ../third_party/perf_data_converter/src/quipper/binary_data_utils.h:16,
from ../third_party/perf_data_converter/src/quipper/perf_parser.h:20,
from ../sample_reader.h:18,
from ../profile.h:15,
from ../profile.cc:5:
../third_party/perf_data_converter/src/quipper/base/logging.h:143: note: this is the location of the previous definition
143 | #define DCHECK_NE(x, y) CHECK_NE(x, y)
|
In file included from ../third_party/glog/src/base/commandlineflags.h:62,
from ../profile.cc:13:
third_party/glog/glog/logging.h:1009: warning: "DCHECK_EQ" redefined
1009 | #define DCHECK_EQ(val1, val2) CHECK_EQ(val1, val2)
|
In file included from ../third_party/perf_data_converter/src/quipper/binary_data_utils.h:16,
from ../third_party/perf_data_converter/src/quipper/perf_parser.h:20,
from ../sample_reader.h:18,
from ../profile.h:15,
from ../profile.cc:5:
../third_party/perf_data_converter/src/quipper/base/logging.h:144: note: this is the location of the previous definition
144 | #define DCHECK_EQ(x, y) CHECK_EQ(x, y)
|
In file included from ../third_party/glog/src/base/commandlineflags.h:62,
from ../profile.cc:13:
third_party/glog/glog/logging.h:1010: warning: "DCHECK_NE" redefined
1010 | #define DCHECK_NE(val1, val2) CHECK_NE(val1, val2)
|
In file included from ../third_party/perf_data_converter/src/quipper/binary_data_utils.h:16,
from ../third_party/perf_data_converter/src/quipper/perf_parser.h:20,
from ../sample_reader.h:18,
from ../profile.h:15,
from ../profile.cc:5:
../third_party/perf_data_converter/src/quipper/base/logging.h:143: note: this is the location of the previous definition
143 | #define DCHECK_NE(x, y) CHECK_NE(x, y)
|
...
```
Contributor guide
Assessment
This issue has not been assessed yet.