google / google/aqt

Support Python versions <3.10

Open
#703 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
361
Forks
33
Avg merge
18h 9m
Merged PRs (30d)
4

Description

Currently this library requires Python 3.10, but does not specify this in setup.py.

For example with Python 3.9, I receive
```python
Python 3.9.17 | packaged by conda-forge | (main, Aug 10 2023, 07:02:31)
[GCC 12.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import aqt.jax.v2.flax.aqt_flax as aqt
Traceback (most recent call last):
File "", line 1, in
File "/home/martin/miniconda3/envs/sd/lib/python3.9/site-packages/aqt/jax/v2/flax/aqt_flax.py", line 432
match self.lhs_freeze_mode:
^
SyntaxError: invalid syntax
>>> import aqt.jax.v2.config as aqt_config
Traceback (most recent call last):
File "", line 1, in
File "/home/martin/miniconda3/envs/sd/lib/python3.9/site-packages/aqt/jax/v2/config.py", line 18, in
from typing import Literal, Optional, TypeAlias, Union
ImportError: cannot import name 'TypeAlias' from 'typing' (/home/martin/miniconda3/envs/sd/lib/python3.9/typing.py)
```

In general it would be nice to at least support Python 3.8 as it's still quite commonly used as a stable Python version.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.