google / google/apitools

Importing from apitools.base.py submodules is slow

Open
#232 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
157
Forks
131
PR merge metrics
No merged PRs in 30d

Description

`apitools/base/py/__init__.py` imports everything from all of its submodules. This makes it easier to import things in the submodules, as you don't have to worry about which submodule its in, but it comes at the price of significant overhead when importing anything from any of the submodules, as all of the submodules (and everything they import) have to be imported too. On my machine, this takes about 160ms. These imports should be removed as wildcard imports in an `__init__.py` file are generally bad practice and have specific consequences in this case.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.