google / google/amber

Skip unsupported files instead of exiting

Open
#957 0 comments 0 reactions 1 assignee Claimed by @dj2 View on GitHub
Dominant language
C++
Stars
228
Forks
77
PR merge metrics
No merged PRs in 30d

Description

Currently Amber exits before creating a Vulkan device [1] if any given file has unmet requirements [2].

Also see: #678

1. [ConfigHelperVulkan::CreateConfig](https://github.com/google/amber/blob/aaac58d5009e8f6b33e2723258dc1542854d09a4/samples/config_helper_vulkan.cc#L1213-L1216)
2. [ConfigHelperVulkan::ChooseVulkanPhysicalDevice](https://github.com/google/amber/blob/aaac58d5009e8f6b33e2723258dc1542854d09a4/samples/config_helper_vulkan.cc#L928-L934)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.