google / google/amber

"end" in a token seen as END

Open
#955 0 comments 0 reactions 1 assignee Claimed by @dj2 View on GitHub
Dominant language
C++
Stars
228
Forks
77
PR merge metrics
No merged PRs in 30d

Description

Given this fragment shader

SHADER fragment frag GLSL
#version 450
#extension GL_ARB_separate_shader_objects : enable
#def RENDERX XXX
void main() {;}
END

amber sees the RENDERX as R END ERX ( the call to extractToNext does not make sure this is a full token)
it does wait for an uppercase END so this mostly messes up with macros

example_4_bad: 16: SHADER missing END command

Is is kind of an odd error message as well since its actually an extra END

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.