google / google/amber

Incorrect component format check

Open
#691 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
228
Forks
77
PR merge metrics
No merged PRs in 30d

Description

If I create a buffer with `BUFFER framebuffer FORMAT B8G8R8A8_UNORM` and then inside buffer.cc call `format_->IsUint8()` it returns false because of `type_->IsNumber()` check. `type::Type::IsUint8(segment.GetFormatMode(), segment.GetNumBits())` works as expected.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.