google / google/amber

Add comments to private data members of buffer.h to determine the single source of truth

Open
#599 1 comment 0 reactions 0 assignees View on GitHub
documentation
Dominant language
C++
Stars
228
Forks
77
PR merge metrics
No merged PRs in 30d

Description

There's a fragile disconnect between setting max_size_in_bytes_, element_count_ and resizing the bytes_ vector. No single one of them is the source of truth.
Write comments at their member declarations to define exactly what they mean, and therefore determine the single source of truth.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.