google / google/adk-web

Subpath routing is broken.

Open
#95 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1k
Forks
267
Avg merge
1d 12h
Merged PRs (30d)
9

Description

https://github.com/google/adk-web/issues/218 describes how can the web-ui be deployed to as subpath, but https://github.com/google/adk-web/blob/03b23e615db45ec912bf75aae1259cafad03c5d6/src/app/core/services/agent.service.ts#L111 does not pick it correctly, because it takes the serverDomain from [here](https://github.com/google/adk-web/blob/03b23e615db45ec912bf75aae1259cafad03c5d6/src/app/core/services/agent.service.ts#L28) which takes the base url from [here](https://github.com/google/adk-web/blob/03b23e615db45ec912bf75aae1259cafad03c5d6/src/utils/url-util.ts#L39)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.