google / google/adk-samples

[BUG]: python/agents/deep-search README Cloud Deployment section is broken

Open
#2,575 4 comments 1 reaction 2 assignees Claimed by @happyhuman View on GitHub
bug documentation python
Dominant language
Python
Stars
10.3k
Forks
2.9k
Avg merge
1d 10h
Merged PRs (30d)
66

Description

### Name of sample affected

python/agents/deep-search

### Description of issue

Instructions under Cloud Deployment section cannot be followed
It mentions `make deploy IAP=true` but Makefile does not contain `deploy` target

`agents-cli create my-deep-search-agent -a adk@deep-search` instruction above also seems to be generating a completely unrelated project called `deep_search` parallel to `app`, so there are 2 `agent.py` files.
There is a Dockerfile automatically created after `agents-cli create` which does `COPY ./deep_search ./deep_search`.
`deep_search` and its `agent.py` inside does not look like it is related to React.
I am expecting `agents-cli create` to create a Dockerfile with both the frontend folder and app folder copied into the image.

Please correct documentation to explain what's the correct `agents-cli create` command to setup the full stack project that's using the frontend folder, with the backend `agent.py` being in `app` folder instead.

How does the React front end communicate with the deployed agent?
Will frontend also be in the same container with the `agent.py` backend?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.