google / google/adk-go

Add custom list of Secrets to Agent Engine deployment

Open
#849 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
8.8k
Forks
1k
Avg merge
3d 18h
Merged PRs (30d)
88

Description

Default GOOGLE_API_KEY is required only if you use API key for Gemini API.
If not set in the project, prevents the container from proper starting.

### Proposed Solution
Instead of hardcoded GOOGLE_API_KEY the cli `adkgo deploy agentengine` should support providing a custom list of secrets to be mapped to Env variables in the container.

--secret=ENV_VARIABLE=SECRET:VERSION
Regex: ([^=]+)=(.*):(.*)
$1 - target Env variable
$2 - secret name as defined in the project
$3 - version (specific or "latest")

The provided list should be used as:
SecretEnv: []*aiplatformpb.SecretEnvVar{
{Name: "ENV_VARIABLE", SecretRef: &aiplatformpb.SecretRef{Secret: "SECRET", Version: "VERSION"}},
},

Contributor guide

Open the contributing guide

Research direction

Start at the `adkgo deploy agentengine` entry point and trace the existing hardcoded `GOOGLE_API_KEY` handling into the Agent Engine deployment request. Implement parsing for repeated `--secret=ENV_VARIABLE=SECRET:VERSION` values and verify that the resulting deployment uses the specified `SecretEnv` mappings instead of the default secret.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, google-cloud
Domain
cli, cloud, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.