google / google/GoogleSignIn-iOS

Does GoogleSignIn have plan to support scene-based lifecycle ?

Open
#85 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Objective-C
Stars
750
Forks
282
Avg merge
2d 15h
Merged PRs (30d)
9

Description

https://github.com/google/GoogleSignIn-iOS/blob/833ff092ce8872102499e52712d9a666d0d87cca/GoogleSignIn/Sources/GIDEMMErrorHandler.m#L96

Hi guys, recently my app decide to migrate from app-based lifecycle to scene-based lifecycle. It means that every UIWindow instance must connect to a specific UIWindowScene instance otherwise your window will not appear on the screen.

In the code above, you can see the error alert window is not connected to the scene. That's might cause a problem under scene-based lifecycle.

Do you have plan to support it ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.