google / google/GoogleSignIn-iOS

Add App Check support for macOS

Open
#602 0 comments 0 reactions 0 assignees View on GitHub
enhancement triage
Dominant language
Objective-C
Stars
750
Forks
282
Avg merge
2d 15h
Merged PRs (30d)
9

Description

**Is your feature request related to a problem you're having? Please describe.**
App Check is currently not supported on macOS. The `GIDSignIn.sharedInstance.configure` method, which is required to enable App Check, is only available on iOS.

Looking at the source code, App Check related code is wrapped in `#if TARGET_OS_IOS && !TARGET_OS_MACCATALYST`, which confirms that macOS is intentionally excluded from the current implementation.

**Describe the solution you'd like**
Please add App Check support for macOS so that `GIDSignIn.sharedInstance.configure` (or an equivalent method) can be called on macOS as well.

**Describe alternatives you've considered**
No alternatives have been found. macOS apps are currently forced to run without App Check.

**Additional context**
Relevant source file: `GoogleSignIn/Sources/GIDSignIn.m`

```objc
#if TARGET_OS_IOS && !TARGET_OS_MACCATALYST
#import
#import "GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.h"
// ...
#endif // TARGET_OS_IOS && !TARGET_OS_MACCATALYST
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.